Skip to content

feat: Replace unsafe numeric casting #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Replace unsafe numeric casting #168

wants to merge 2 commits into from

Conversation

varun-doshi
Copy link
Contributor

@varun-doshi varun-doshi commented Feb 3, 2025 •
edited
Loading

Ref #81

This PR will break down the unsafe conversions in the following steps(respective commits):

  • u32
  • u8
  • u64
  • u128(if any)

Will update this description as progress is made on the other types.

@varun-doshi
Copy link
Contributor Author

Note: looks like all the u8 casts are safe since they are mostly always bound by loops or are the numerical representation of enums

@varun-doshi varun-doshi mentioned this pull request Feb 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@varun-doshi