Skip to content

Connect F4E gitlab to JADE #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: developing
Choose a base branch
from
Open

Connect F4E gitlab to JADE #372

wants to merge 2 commits into from

Conversation

dodu94
Copy link
Member

@dodu94 dodu94 commented Mar 19, 2025

Description

This PR allows jade to fetch also inputs from the F4E private GitLab in case an access token is provided in the enviromental variables config file.

Additional dependencies introduced.

  • python-gitlab

Type of change

Please select what type of change this is.

  • Bug fix (non-breaking change which fixes an issue)
  • New benchmark
    • Non-breaking change which entirely uses exisiting classes, structure etc
    • Breaking change which has implemented new/modified classes etc
  • New feature
    • Non-breaking change which adds functionality
    • Breaking change fix or feature that would cause existing functionality to not work as expected

Other changes

  • This change requires a documentation update
  • (If Benchmark) This requires additional data that can be obtained from:
    • Benchmark data 1
    • Benchamrk data 2

Testing

Suitable tests have been added for the CI suite

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • General testing
    • New and existing unit tests pass locally with my changes
    • Coverage is >80%

@dodu94
Copy link
Member Author

dodu94 commented Mar 19, 2025

Apparently the address of the F4E GitLab is not publicly available. If this situation is not solved, fetching cannot be tested in the GitHub CI and external users will not be able to access it without having a F4E VPN installed

@dodu94
Copy link
Member Author

dodu94 commented Mar 20, 2025

Update: Discussion with IT is ongoing to publish the website. Only drawback would be the necessity of 2FA for web access (but no impact on token-style access)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant