Skip to content

Added support for _NET_WM_STATE_BELOW and window_below command #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

a0405u
Copy link

@a0405u a0405u commented May 22, 2025

Solved the issue I mentioned. WM now reads _NET_WM_STATE_BELOW when managing window and saves it in client.below. Raising the window is now made with the respect to _NET_WM_STATE_BELOW and client.below. Always below state can now be toggled with berryc window_below command. I had to rearrange client_manage_focus and switch_ws in ipc_pointer_focus because swith_ws was focusing top most window after handling the switch and it moved the focus away from the bottom window that you're trying to point on.

@a0405u
Copy link
Author

a0405u commented May 23, 2025

Removed client->below completely. Now everything is done dynamically according to current _NET_WM_STATE, even if it was set or changed by the application bypassing berry.

JLErvin
JLErvin previously approved these changes May 23, 2025
@a0405u
Copy link
Author

a0405u commented May 24, 2025

One thing that's left is to add window_below to docs and help, but I'm not sure how exactly. Should I edit berryc.1 or is it generated?

@JLErvin
Copy link
Owner

JLErvin commented May 24, 2025

One thing that's left is to add window_below to docs and help, but I'm not sure how exactly. Should I edit berryc.1 or is it generated?

Yes, edit berryc.1. The man files are generated/installed as part of the make process.

For the website, you'll need to make a separate PR in https://github.com/JLErvin/berry-doc. Sadly the process is not tied to the man page build process at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants