Fix dependency issue for git hook tasks #837
Open
+10
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2025 13:24
wakingrufus
reviewed
Feb 25, 2025
| @get:InputDirectory | ||
| internal val rootDirectory: DirectoryProperty = objectFactory.directoryProperty().apply { | ||
| set(project.rootDir) | ||
| @get:Input |
There was a problem hiding this comment.
this is the correct way to make an input depend on the path and not the contents 👍
wakingrufus
reviewed
Feb 25, 2025
| } | ||
|
|
||
| @TaskAction | ||
| fun installHook() { | ||
| val repo = RepositoryBuilder().findGitDir(projectDir.get().asFile).setMustExist(false).build() |
There was a problem hiding this comment.
I think we have some work to do in terms of properly making this task depend on the git directory as an input. But i think this PR is fine for now and we can refine later
|
Thanks for the contribution! please update the changelog file (see the failed check for this for details). I am approving the ci checks to run, and once everything passes, I will open to merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running one of the Git hook tasks together with another task, Gradle will complain with an error:
This is caused by
@InputDirectorymarking the entire project root and contents as input, so any task that modifies any file in the project will cause Gradle to add an implicit dependency.You can see this behaviour by running
./gradlew compileKotlin addKtlintCheckGitPreCommitHook.Build result on the first commit of this PR, to show it failing: https://github.com/ntkoopman/ktlint-gradle/actions/runs/13514290368/job/37760683637
This is the same issue as #545, except this PR keeps the inputs.