refactor(tests): remove remaining explicit any from test files - #448
Open
Okorie2000-code wants to merge 3 commits into
Open
refactor(tests): remove remaining explicit any from test files#448Okorie2000-code wants to merge 3 commits into
Okorie2000-code wants to merge 3 commits into
Conversation
|
@Okorie2000-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Okorie2000-code
force-pushed
the
refactor/remove-test-any
branch
from
July 27, 2026 19:31
9d616cc to
0a23f65
Compare
Remove the insecure behavior where verifySignature() silently accepted requests when STELLAR_WEBHOOK_SECRET was not configured. - Throw InternalServerErrorException instead of returning silently - Log an explicit configuration error (stellar.webhook.config_error) - Distinguish config errors from invalid signatures via exception type - Make STELLAR_WEBHOOK_SECRET Joi-required in production - Update .env.example to document the production requirement - Update all unit/integration tests to expect rejection Closes JSE-ORG#421
Contributor
|
fix your conflict and rebase on dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Closes #
How
Checklist
npm run validatepasses locally (typecheck, lint, test)anytypes introducedfix(escrow): correct auto release eligibility queryNotes for the reviewer
closes #416