Skip to content

chore(engine): remove dead isDuplicateClusterWinner (its own @deprecated comment describes callers that don't exist) #6172

Description

@JSONbored

Context

packages/loopover-engine/src/duplicate-winner.ts:46 (JSDoc at lines 43-44) marks isDuplicateClusterWinner @deprecated ... retained only for legacy compatibility callers that do not have claim timestamps. A repo-wide grep across packages/loopover-engine, packages/loopover-miner, and src/** finds zero real call sites — only re-exports (index.ts, src/signals/duplicate-winner.ts) and {@link} mentions in unrelated comments (src/queue/duplicate-detection.ts, src/services/maintainer-activation.ts). The legacy callers the deprecation comment describes don't actually exist anywhere in the current codebase.

Requirements

  • Confirm via a fresh repo-wide search (including the re-export chain through index.ts/src/signals/duplicate-winner.ts) that isDuplicateClusterWinner truly has zero real callers, not just zero direct callers.
  • Remove isDuplicateClusterWinner and its re-exports.
  • Update the {@link} mentions in src/queue/duplicate-detection.ts and src/services/maintainer-activation.ts to stop referencing a function that no longer exists.

Deliverables

  • isDuplicateClusterWinner and its re-exports removed.
  • Stale {@link} references updated.
  • Existing tests for duplicate-winner.ts's remaining exports continue passing.

Expected Outcome

No deprecated dead function remains whose own justifying comment describes callers that don't exist in the current codebase.

Links & Resources

  • packages/loopover-engine/src/duplicate-winner.ts:43-46
  • src/queue/duplicate-detection.ts, src/services/maintainer-activation.ts (stale {@link} mentions)

Metadata

Metadata

Assignees

No one assigned

    Labels

    gittensor:bugGittensor-scored bug fix — scores a 0.05x multiplier.help wantedExtra attention is needed

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions