Skip to content

BYOK: per-record PBKDF2 salt for at-rest key derivation (defense-in-depth) #677

Description

@JSONbored

Part of #525. From the BYOK security audit.

deriveSecretAesKey (src/utils/crypto.ts) uses a single static salt for all keys. Acceptable today (single high-entropy TOKEN_ENCRYPTION_SECRET; per-record random IV already guarantees ciphertext uniqueness) — defense-in-depth only.

Fix (optional): generate a random salt per encryption, store it alongside iv/keyVersion, pass to deriveSecretAesKey on decrypt; gate behind keyVersion so existing v1 rows keep the constant salt. Requires a migration (new column).

Severity: low (audit rated acceptable; deferred unless rotation/KDF change is needed).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions