Skip to content

ci: revert concurrency expression to literal (fix startup_failure / stuck validate) - #1010

Merged
JSONbored merged 1 commit into
mainfrom
fix/revert-ci-concurrency-expression
Jun 22, 2026
Merged

ci: revert concurrency expression to literal (fix startup_failure / stuck validate)#1010
JSONbored merged 1 commit into
mainfrom
fix/revert-ci-concurrency-expression

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

#1006 changed cancel-in-progress to an expression ${{ github.event_name == 'pull_request' }}. GitHub fails ci.yml at startup with that form on both push and pull_request — so validate/test/lint jobs are never created and the required validate check sits stuck at waiting, blocking #1007 and every new PR. actionlint accepts the expression; GitHub's runtime parser won't start the run.

Reverts to the known-good literal cancel-in-progress: true (green at 9df11d07). Surgical — only that one line changes; all security hardening (checkout head-SHA pinning at the 6 checkout steps, permissions: contents: read) is untouched.

The expression form (cancel-in-progress: ${{ github.event_name == 'pull_request' }}) from #1006
caused GitHub to fail ci.yml at startup (startup_failure) on both push and pull_request, so the
required `validate` check never reported and PRs sat stuck 'waiting'. actionlint accepts the
expression but GitHub's runtime parser does not start the run. Revert to the known-good literal.
@dosubot dosubot Bot added the size:XS label Jun 22, 2026
@ghost

ghost commented Jun 22, 2026

Copy link
Copy Markdown

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal Result Evidence Action
Gate result ⚠️ Skipped #1010 is no longer open. No action.

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added the gittensory:reviewed label Jun 22, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@JSONbored JSONbored self-assigned this Jun 22, 2026
@JSONbored
JSONbored merged commit af23df2 into main Jun 22, 2026
8 checks passed
@JSONbored
JSONbored deleted the fix/revert-ci-concurrency-expression branch June 22, 2026 09:07
@ghost ghost added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant