perf(cron): backpressure the re-gate sweep on the GitHub REST budget - #1483
Merged
Conversation
The auto-maintain sweep — the heaviest GitHub-budget consumer (per-repo + per-PR live CI + mergeable fetches) — was enqueued unconditionally every ~2-minute cron tick, so on a busy install it competed with webhooks for the shared hourly REST bucket and compounded the backlog. The sweep is now skipped for a tick when the budget is already at/below MAINTENANCE_RESERVED_HEADROOM, reserving the remaining budget for webhooks (which drive timely reviews); the next tick retries and the sweep resumes after the bucket resets. Webhooks never pre-yield.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 194 194
Lines 21070 21074 +4
Branches 7624 7625 +1
=======================================
+ Hits 20110 20114 +4
Misses 383 383
Partials 577 577
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The auto-maintain re-gate sweep — the heaviest GitHub-budget consumer (per-repo + per-PR live CI + mergeable fetches) — was enqueued unconditionally every ~2-minute cron tick. On a busy install it competed with webhooks for the shared hourly REST bucket and compounded the backlog.
The sweep is now skipped for a tick when the REST budget is already at/below
MAINTENANCE_RESERVED_HEADROOM(150), reserving the remaining budget for webhooks (which drive timely reviews). The next tick (~2 min) retries, and the sweep resumes once the bucket resets. Webhooks never pre-yield. This reuses the existingshouldWaitForGitHubRateLimitgate, so it works on cloud and self-host.Validation
npm run typecheck;npm run test:coverage— full suite green; 100% changed lines + branches (a low-budget observation throttles the sweep; the existing tests cover the normal enqueue).Roadmap item #6 (throughput / fairness).