fix(queue): thread deliveryId into runAgentMaintenancePlanAndExecute - #2427
Conversation
#2403 referenced args.deliveryId on a plan-and-execute context that never declared or received the field, breaking typecheck on main. Thread it through from the caller and backfill the ciCompletenessWarning field on existing LiveCiAggregate test mocks that predated that type change.
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-01 22:30:13 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2427 +/- ##
=======================================
Coverage ? 95.85%
=======================================
Files ? 224
Lines ? 25104
Branches ? 9129
=======================================
Hits ? 24064
Misses ? 427
Partials ? 613
🚀 New features to boost your workflow:
|
Summary
#2403referencedargs.deliveryIdinsiderunAgentMaintenancePlanAndExecute, but that function'sargstype never declared or received the field — a typecheck break that reachedmain.deliveryIdthrough from the caller (maybeRunAgentMaintenance, which already has it) and backfills theciCompletenessWarningfield on 8 pre-existingLiveCiAggregatetest mocks that predated that type's new required field.Test plan
npm run typecheckcleannpm run test:coverage: 312 files / 5821 tests passing, no threshold failuresnpm audit --audit-level=moderate: 0 vulnerabilitiestest/unit/queue.test.tsverifiesdeliveryIdnow actually lands in thegithub_app.ci_completeness_unverifiedaudit event's metadata