fix(commands): guard command authorization preview lookups - #503
Merged
JSONbored merged 1 commit intoJun 10, 2026
Merged
Conversation
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 0738737 | Commit Preview URL Branch Preview URL |
Jun 10 2026, 07:32 AM |
This was referenced Jun 10, 2026
JSONbored
force-pushed
the
codex/fix-settings-preview-crash-from-command-names
branch
from
June 10, 2026 07:20
06aff27 to
6dc47be
Compare
JSONbored
force-pushed
the
codex/fix-settings-preview-crash-from-command-names
branch
from
June 10, 2026 07:31
6dc47be to
0738737
Compare
JSONbored
deleted the
codex/fix-settings-preview-crash-from-command-names
branch
June 10, 2026 07:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
commandNamevalues that are inherited object properties (for exampleconstructor,toString,__proto__) are indexed onnormalized.commandsand then passed todedupeRoles, which caused aTypeErrorand availability impact.Description
Object.hasOwn(normalized.commands, commandName)before readingnormalized.commands[commandName]so prototype properties do not get treated as command role arrays and instead fall back tonormalized.default, and add unit coverage intest/unit/command-authorization.test.tsexercising inherited property names throughcommandAuthorizationAllowedRolesandevaluateCommandAuthorization.Testing
npx vitest run test/unit/command-authorization.test.ts --pool=threads --reporter=defaultandnpm run typecheck, both succeeded, andgit diff --checkreported no issues.Codex Task