fix(queue): complete #5021's cron-path fix -- the fan-out dispatcher itself was still isRegistered-gated - #5694
Conversation
…itself was still isRegistered-gated #5021 retargeted the two downstream entry points (backfillRegisteredRepositories, enqueueRepositoryOpenDataBackfill) from isRegistered to isInstalled, but never touched the actual candidate- selection step for the periodic (30-min) cron sweep: processJob's "backfill-registered-repos" no-repoFullName branch in job-dispatch.ts still filtered listRepositories() on isRegistered before ever dispatching a per-repo job. An installed-but-not-subnet-registered repo therefore never got a per-repo backfill job enqueued for it in the first place -- #5021's fix never actually took effect on the real cron path, only on direct/API- triggered single-repo calls. Found via a full-codebase audit of remaining isRegistered call sites after #5021 merged. Part of #5016
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5694 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 577 577
Lines 45978 45978
Branches 14724 14724
=======================================
Hits 43689 43689
Misses 1530 1530
Partials 759 759
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-14 05:34:23 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agent
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
backfillRegisteredRepositories,enqueueRepositoryOpenDataBackfill) fromisRegisteredtoisInstalled, but never touched the actual candidate-selection step for the periodic (30-min) cron sweep.processJob's"backfill-registered-repos"no-repoFullNamebranch insrc/queue/job-dispatch.tsstill filteredlistRepositories()onisRegisteredbefore ever dispatching a per-repo job.isRegisteredcall sites run after Retarget the backfill-registered-repos job family from isRegistered to isInstalled #5021 merged, specifically to check whether anything else needed the same treatment.Test plan
repoFullName) includes an installed-but-not-registered repo and excludes a registered-but-not-installed onenpm run test:ci— full local gate, clean (run twice for stability; one unrelatedselfhost-ai.test.tssubprocess-timing flake on the first run, confirmed passing 165/165 in isolation and on the clean second run)Part of #5016