fix(rebrand): rename double-underscore global identifiers missed by Phase 6 - #5756
Merged
Conversation
…hase 6 __gittensoryMinerOpportunityBadge and 5 sibling window-scoped globals in the extension/miner-extension test-hook internals survived Phase 6's sweep because they weren't covered by either the initial sed pass or the later perl-based fix for non-underscore-prefixed identifiers.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5756 +/- ##
=======================================
Coverage 95.07% 95.07%
=======================================
Files 581 581
Lines 46181 46181
Branches 14811 14811
=======================================
Hits 43905 43905
Misses 1516 1516
Partials 760 760
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gittensory*code identifiers toloopover*, but 6 double-underscore-prefixed window-scoped globals used by the extension/miner-extension test-hook internals were accidentally excluded from both the initial rename pass and the later fix-up pass.__gittensoryMinerOpportunityBadge(TestExports),__gittensoryMinerBackgroundInternals,__gittensoryMinerToolbarBadge,__gittensoryMinerOptionsInternals,__gittensoryMinerContentInternals, and__gittensoryContentInternalsto their__loopover*equivalents across 11 files (extension/miner-extension source + their unit tests).Test plan
npm run typecheckcleannpx vitest run— 16230 passed (2 pre-existing local-only failures inminer-repo-clone.test.tsunrelated to this change, caused by the local commit-signing gate on temp git repos, not present in CI)npm run docs:drift-check/npm run manifest:drift-checkclean