fix(review): trim the Improvement signal row to a concise value rating - #5767
Conversation
The Improvement row's Evidence cell (JSONbored#4744/JSONbored#4745) concatenated the deterministic finding sentences + the full LLM rationale into one paragraph-in-a-cell. Per maintainer feedback (JSONbored#5101: 'a quick, clean, simple score/rating ... not a paragraph'), the cell is now just the risk x value quadrant tagged with the LLM's one-word magnitude (e.g. 'risk: low · value: minor · LLM: significant'), falling back to 'value: <band>' when slop wasn't computed this pass. Because only closed-enum band/magnitude names are interpolated now — never the free-text finding detail or LLM rationale — the cell is public-safe by construction, so the old containsPrivatePublicTerm filtering it needed is removed (the now-unused improvementEvidenceText helper is deleted). Closes JSONbored#5101
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5767 +/- ##
==========================================
- Coverage 95.07% 95.07% -0.01%
==========================================
Files 581 581
Lines 46181 46172 -9
Branches 14811 14807 -4
==========================================
- Hits 43905 43896 -9
Misses 1516 1516
Partials 760 760
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-14 13:10:55 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 3 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
The optional "Improvement" signal row (#4744/#4745) rendered its Evidence cell as a wall of text — the deterministic finding sentences plus the full LLM rationale concatenated into one cell (confirmed from a live rendering). The maintainer feedback in #5101 asks for "a quick, clean, simple score/rating … not a paragraph."
This makes the cell a concise rating:
risk: low · value: minor · LLM: significant.value: <band>when slop wasn't computed this pass (no quadrant), never fabricating a risk reading.Bonus safety win: because only closed-enum band/magnitude names are interpolated now (never free-text finding detail or LLM rationale), the cell is public-safe by construction — so the
containsPrivatePublicTermfiltering the old free-text evidence needed is removed, and the now-unusedimprovementEvidenceTexthelper is deleted.Scope
type(scope): short summaryConventional Commit format.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #5101.Validation
git diff --checknpm run typecheck— clean on the changed filessignals-coverage,queue-4, plusai-review,ai-review-advisory,feature-activation,visual-wire(431 tests across the 6 affected files)If any required check was skipped, explain why:
src/signals/engine.tsbuilds PR-comment markdown text, not a UI page), so there is no UI Evidence / screenshot to attach — the output is asserted via unit tests instead.Safety
Notes
Closes #5101