fix(selfhost): default miner prometheus export script to the real bin name - #6000
Conversation
… name scripts/export-miner-prometheus-textfile.sh defaulted MINER_BIN to gittensory-miner, which is not an installable binary after the rebrand's hard cutover, so an operator running the script with no LOOPOVER_MINER_BIN override hits command-not-found and (since export_family is fail-open) silently produces an empty .prom on every run. Default MINER_BIN to the package's real bin entry loopover-miner, refresh the matching command reference in the header comment, and add a test/unit regression guard. Closes JSONbored#5934
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-15 06:31:26 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 3 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Closes #5934.
scripts/export-miner-prometheus-textfile.shdefaultedMINER_BINtogittensory-miner, which is not an installable binary after the rebrand's hard cutover — the package's realbinentry isloopover-miner. An operator running the script with noLOOPOVER_MINER_BINoverride (the documented usage) hitscommand not found(exit 127) on the first call, and becauseexport_familyis fail-open, all four metric families silently fail and the.promis never populated.Changes
scripts/export-miner-prometheus-textfile.sh:MINER_BINdefaultgittensory-miner→loopover-miner. Refreshed the one matching`gittensory-miner metrics`command reference in the header comment. TheLOOPOVER_MINER_BINoverride mechanism is unchanged.test/unit/miner-prometheus-textfile-export.test.ts(new): the regression guard the issue asks for —readFileSync+ assert the defaultMINER_BINisloopover-minerand the hyphenatedgittensory-minerbinary name is gone. Mirrorstest/unit/miner-docker-compose.test.ts.OUT_FILE decision
Per the issue's note, I deliberately left
OUT_FILE's default filename…/gittensory_miner.promunchanged. It is a cosmetic filename, not a functional break like the binary — renaming it would silently move where the textfile lands and could break operators' existing node_exporter/dashboard wiring keyed on that path. The regression test asserts on the hyphenated binary name only, so it does not touch this separate underscore filename.Validation
sh -nclean on the script.loopover-mineris the real bin entry (packages/loopover-miner/package.json) and no existing test asserted the old default.scripts/**is outside Codecov'scoverage.include, so no patch-coverage gate applies.