chore(signals): remove dead deriveContributionLanes superseded by onboarding-pack's contribution-lane model

[real-venus]

Summary

src/signals/focus-manifest.ts's deriveContributionLanes (plus its ContributionLanes / ContributionLanePreference types and its only-caller helper buildLanesSummary) is a superseded, orphaned implementation with zero production callers -- a repo-wide search finds it only in its own two test blocks. Production contributor-guidance output flows through the separately-shaped RepoPolicyContributionLane / RepoOnboardingContributionLane model in src/signals/onboarding-pack.ts (sourced from the richer repo-policy compiler, with its own public-safe sanitizeContributionLane), which supersedes the raw-manifest derivation deriveContributionLanes predates.

Changes

• Removed deriveContributionLanes, its ContributionLanes / ContributionLanePreference types, and the private buildLanesSummary helper (used only by it) from src/signals/focus-manifest.ts.
• Removed its dedicated test blocks from test/unit/focus-manifest.test.ts and test/unit/policy-sanitizer.test.ts, plus the now-unused imports.
• Pure deletion: 404 lines removed, 0 added. The engine's separate buildPolicyContributionLanes model (the production path) is untouched.

Confirmation (per the issue's requirements)

• Repo-wide search: deriveContributionLanes and its types have zero callers outside their own tests.
• The engine twin packages/loopover-engine/src/focus-manifest.ts never had deriveContributionLanes (it lived only in the app-local shim), so there is no parity pair to keep in sync -- check-engine-parity.ts still passes.
• onboarding-pack.ts's model genuinely covers the same public-safe contribution-guidance use case, sourced from the repo-policy compiler rather than a raw manifest -- the intended successor.

Scope

• Dead-code removal only; no behavior change (no production code path referenced the removed function).

Validation

• npm run typecheck -- clean (no dangling refs / unused imports).
• npx vitest run test/unit/focus-manifest.test.ts test/unit/policy-sanitizer.test.ts -- 689 passed.
• scripts/check-engine-parity.ts -- ok.
• git diff --check clean; rebased onto latest main, mergeable-clean.

Safety

• No secrets/private terms. Removing a public-safe helper that nothing calls cannot change any live output.

Closes #6167

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (00c14a5) to head (bbe1a4c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6220      +/-   ##
==========================================
- Coverage   95.32%   95.31%   -0.01%     
==========================================
  Files         596      596              
  Lines       47099    47046      -53     
  Branches    15010    14985      -25     
==========================================
- Hits        44897    44844      -53     
  Misses       1477     1477              
  Partials      725      725              

Flag	Coverage Δ
shard-1	44.02% <ø> (-0.01%)	⬇️
shard-2	36.84% <ø> (+0.18%)	⬆️
shard-3	32.20% <ø> (-0.02%)	⬇️
shard-4	34.05% <ø> (-0.06%)	⬇️
shard-5	31.59% <ø> (-0.09%)	⬇️
shard-6	45.26% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/signals/focus-manifest.ts	99.58% <ø> (-0.08%)	⬇️

[loopover-orb]

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-15 23:06:33 UTC}

3 files · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This is a pure dead-code deletion: removes the unused `deriveContributionLanes` function, its `ContributionLanes`/`ContributionLanePreference` types, and the private `buildLanesSummary` helper from focus-manifest.ts, plus their dedicated test blocks in two test files. The retrieved onboarding-pack context (`buildPolicyContributionLanes`) confirms a structurally equivalent, actively-wired successor already exists and is untouched, supporting the PR's claim of zero production callers. The removed imports in both test files are cleaned up correctly and no other exported symbol from focus-manifest.ts is touched.

Nits — 3 non-blocking

• The PR description doesn't cite a specific issue number it closes, which this repo's contribution policy requires for external PRs — worth confirming the linked issue before merge.
• Run a final repo-wide grep for `deriveContributionLanes`/`ContributionLanes`/`ContributionLanePreference` post-merge to confirm no re-export or type-only usage was missed outside the two files shown.
• Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#6167
Related work	⚠️ 2 scoped overlaps	Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope	❌ 8/20	High review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 139 registered-repo PR(s), 75 merged, 21 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	real-venus; Gittensor profile; 139 PR(s), 21 issue(s).
Gate result	✅ Passing	No configured blocker found.
Improvement	ℹ️ None detected	risk: low · value: none · LLM: minor

Linked issue satisfaction

Addressed
The PR cleanly removes deriveContributionLanes, its ContributionLanes/ContributionLanePreference types, and the buildLanesSummary helper along with all associated tests, matching the issue's 'remove if confirmed superseded' path and its stated confirmation that onboarding-pack.ts's model covers the same use case.

Review context

• Author: real-venus
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: not available
• Official Gittensor activity: 139 PR(s), 21 issue(s).
• Related work: Items reference the same linked issue chore(review): remove dead deriveContributionLanes, superseded by onboarding-pack.ts's own contribution-lane model #6167. (issue #6167)
• Related work: Open PR work references issue chore(review): remove dead deriveContributionLanes, superseded by onboarding-pack.ts's own contribution-lane model #6167. (issue #6167)

Contributor next steps

• Start here: Review top overlaps.
• Then work through the remaining 2 steps in the Signals table above.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver approves — the gate is satisfied and CI is green.