fix(db): renumber colliding migration 0156 to 0157 - #6484
Merged
Conversation
PR #6454 (draft-pr-close-policy) and PR #6467 (screenshot-table-gate-head-sha-correlation) both grabbed migration number 0156, merging 23 minutes apart without seeing each other's number. db:migrations:check now fails on main for every PR. Renumber the later-merged one (#6467) to the next free number.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 4 Tests Failed:
View the top 2 failed test(s) by shortest run time
View the full list of 2 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
draft-pr-close-policy) and PR fix(review): correlate screenshot-table presence-mode evidence to the PR head SHA #6467 (screenshot-table-gate-head-sha-correlation) both claimed migration number0156, merging 23 minutes apart — neither rebased against the other's freshly-landed migration first.db:migrations:check(part ofvalidate-code/test:ci) now fails onmainfor every open and future PR:duplicate migration number 0156.#6467's0156_pull_request_screenshot_table_presence_satisfied.sql) to0157, matching the checker's own suggested resolution. No other file references the old filename/number.Test plan
npm run db:migrations:check— passes (contiguous 0001..0157, next free 0158)npm run db:schema-drift:check— passes (no drift from the rename)