fix(review): correct the per-project fairness-flags tile's row-count label - #7716
Merged
Conversation
…label "Contributor fairness flags" delta said "N contributor(s) evaluated", but contributorGateEval.rows is one row per (login, project) -- a login active on two repos contributes two rows, so the old wording overstated the number of distinct contributors. The new "Global contributor fairness flags" tile already has an accurate per-login count for that.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7716 +/- ##
===========================================
+ Coverage 62.31% 88.59% +26.27%
===========================================
Files 725 84 -641
Lines 76397 20704 -55693
Branches 22758 3660 -19098
===========================================
- Hits 47608 18342 -29266
+ Misses 25083 2184 -22899
+ Partials 3706 178 -3528
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contributorGateEval.rowsis one row per (login, project) -- a login active on two repos contributes two rows, so the old wording overstated the number of distinct contributors.Test plan
npx tsc --noEmitcleanoperator-dashboard.test.ts+api.test.tsgreenoperator-dashboard.ts(verified via lcov)