Skip to content

test(signals): exercise the gittensor_root arm of local-branch's metadataOnly condition #8522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 24, 2026
Merged

test(signals): exercise the gittensor_root arm of local-branch's metadataOnly condition #8522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions test/unit/local-branch.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2225,6 +2225,38 @@ describe("local MCP git metadata collection", () => {
expect(analysis.scenarioSummary.eligibilityNotes.length).toBeGreaterThan(0);
});

it("#8325: covers both operands of the metadataOnly condition, including the gittensor_root arm", () => {
// metadataOnly = scorer?.mode !== "gittensor_root" && scorer?.mode !== "external_command"
// (local-branch.ts:497). Every other mode was covered; "gittensor_root" had zero test cases, so the
// FIRST operand's false arm was never taken. These three cases exercise each operand independently.
const analyze = (localScorer?: { mode: string }) =>
buildLocalBranchAnalysis({
input: {
login: "oktofeesh1",
repoFullName: repo.fullName,
changedFiles: [{ path: "src/cache.ts", additions: 5, deletions: 0, status: "modified" }],
...(localScorer ? { localScorer: localScorer as never } : {}),
},
repo,
issues: [],
pullRequests: [],
profile,
outcomeHistory,
scoringSnapshot,
scoringProfile,
});
const hasMetadataOnly = (analysis: ReturnType<typeof buildLocalBranchAnalysis>) =>
analysis.scorePreview.blockedBy.some((entry) => entry.code === "metadata_only");

// Operand 1 FALSE (short-circuits): a real gittensor_root scorer ran, so the preview is NOT metadata-only.
expect(hasMetadataOnly(analyze({ mode: "gittensor_root" }))).toBe(false);
// Operand 1 TRUE, operand 2 FALSE: external_command is the other real-scorer mode.
expect(hasMetadataOnly(analyze({ mode: "external_command" }))).toBe(false);
// BOTH TRUE: any other mode (or no scorer at all) leaves the preview metadata-only.
expect(hasMetadataOnly(analyze({ mode: "metadata_only" }))).toBe(true);
expect(hasMetadataOnly(analyze())).toBe(true);
});

it("populates scenarioSummary.blockerNotes when the score preview has metadata-only signals", () => {
const analysis = buildLocalBranchAnalysis({
input: {
Expand Down