docs(discovery-index): correct posthog.ts header to the completed Sentry-replacement state - #8633
Conversation
…try-replacement state discovery-index/src/posthog.ts's header still described a parallel-run-alongside-sentry.ts architecture (both sinks active, removal gated on a cross-repo decommission tracker) that no longer exists: sentry.ts was deleted outright and PostHog is the sole error-tracking sink for this package. Rewrite the module header, the "deliberately mirrors sentry.ts's shape" note, the redaction-rules rationale, and the tagValue v8-ignore note to past tense, matching how review-enrichment/src/posthog.ts already documents the identical full-replacement state. Comment-only; no executable code changed. Closes JSONbored#8628
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8633 +/- ##
==========================================
- Coverage 92.77% 90.58% -2.19%
==========================================
Files 798 97 -701
Lines 79464 22561 -56903
Branches 24078 3903 -20175
==========================================
- Hits 73725 20438 -53287
+ Misses 4592 1945 -2647
+ Partials 1147 178 -969
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-25 16:01:10 UTC
Review summary Nits — 3 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
packages/discovery-index/src/posthog.ts's header comment still described an architecture that no longer exists — a parallel-run where PostHog andsentry.tswere both active simultaneously, with Sentry removal gated on a cross-repo decommission checklist. In realitysentry.tswas deleted outright for this package and PostHog is now the sole error-tracking sink (the commit that finished the swap states the epic's revised strategy directly, andpackages/discovery-index/src/sentry.tsno longer exists / has no@sentry/*dependency).This is a comment-only correction — no executable code changed:
review-enrichment/src/posthog.tsalready documents the identical full-replacement state for its own package — while keeping discovery-index's own accurate details (the Cloudflare Container long-running-process deploy target).tagValuev8 ignorenote's "mirrors sentry.ts's … guard" → past tense.Verification
packages/discovery-index/src/**andscripts/**confirms no remaining comment implies Sentry is still active in parallel or gated for this package.Closes #8628