Skip to content

docs(discovery-index): correct posthog.ts header to the completed Sentry-replacement state - #8633

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
xfodev:fix/discovery-index-posthog-header-8628
Jul 25, 2026
Merged

docs(discovery-index): correct posthog.ts header to the completed Sentry-replacement state#8633
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
xfodev:fix/discovery-index-posthog-header-8628

Conversation

@xfodev

@xfodev xfodev commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

packages/discovery-index/src/posthog.ts's header comment still described an architecture that no longer exists — a parallel-run where PostHog and sentry.ts were both active simultaneously, with Sentry removal gated on a cross-repo decommission checklist. In reality sentry.ts was deleted outright for this package and PostHog is now the sole error-tracking sink (the commit that finished the swap states the epic's revised strategy directly, and packages/discovery-index/src/sentry.ts no longer exists / has no @sentry/* dependency).

This is a comment-only correction — no executable code changed:

  • Module header (lines 1-11): rewritten to state plainly that PostHog replaced Sentry entirely (no parallel-run, no cross-repo gating for this surface), matching how review-enrichment/src/posthog.ts already documents the identical full-replacement state for its own package — while keeping discovery-index's own accurate details (the Cloudflare Container long-running-process deploy target).
  • The "deliberately mirrors sentry.ts's shape … parallel-run window" note → past tense, parallel-run framing removed.
  • The redaction-rules "literal copy … parallel-run posture" note → reworded to explain the self-contained (no shared import) rationale in terms of the current architecture.
  • The tagValue v8 ignore note's "mirrors sentry.ts's … guard" → past tense.

Verification

  • A repo-wide grep across packages/discovery-index/src/** and scripts/** confirms no remaining comment implies Sentry is still active in parallel or gated for this package.
  • Diff is comment-only (every changed line is a comment); no new executable branches, so no new tests are required (asserting comment text would exercise no behavior).

Closes #8628

…try-replacement state

discovery-index/src/posthog.ts's header still described a parallel-run-alongside-sentry.ts
architecture (both sinks active, removal gated on a cross-repo decommission tracker) that no
longer exists: sentry.ts was deleted outright and PostHog is the sole error-tracking sink for
this package. Rewrite the module header, the "deliberately mirrors sentry.ts's shape" note, the
redaction-rules rationale, and the tagValue v8-ignore note to past tense, matching how
review-enrichment/src/posthog.ts already documents the identical full-replacement state.
Comment-only; no executable code changed.

Closes JSONbored#8628
@xfodev
xfodev requested a review from JSONbored as a code owner July 25, 2026 15:57
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.58%. Comparing base (b471ee1) to head (fa04d37).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8633      +/-   ##
==========================================
- Coverage   92.77%   90.58%   -2.19%     
==========================================
  Files         798       97     -701     
  Lines       79464    22561   -56903     
  Branches    24078     3903   -20175     
==========================================
- Hits        73725    20438   -53287     
+ Misses       4592     1945    -2647     
+ Partials     1147      178     -969     
Flag Coverage Δ
backend 100.00% <ø> (+6.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/discovery-index/src/posthog.ts 100.00% <ø> (ø)

... and 701 files with indirect coverage changes

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 25, 2026
@loopover-orb

loopover-orb Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-25 16:01:10 UTC

1 file · 1 AI reviewer · no blockers · readiness 93/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a comment-only correction to packages/discovery-index/src/posthog.ts's header and inline notes, updating stale parallel-run/gating language (referencing a still-present sentry.ts) to past-tense, full-replacement phrasing that matches the current reality where sentry.ts has been deleted. The change is consistent with the sibling review-enrichment/src/posthog.ts header already shown as reference, which uses near-identical phrasing for the same architectural state. No executable code is touched, and the diff closes issue #8628 as claimed.

Nits — 3 non-blocking
  • No test changes are included, but that's expected and correct here since comment-only changes exercise no behavior — nothing to flag beyond noting it.
  • Consider a repo-wide follow-up sweep (already partially claimed as verified via grep) to double check no other files outside src/** in discovery-index or scripts/** still reference the old parallel-run/gating language, since this PR only touches one file.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8628
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ⚠️ 20/25 Preflight is ready, but the PR body does not name the validation run.
Contributor workload ✅ 10/10 Author activity: 56 registered-repo PR(s), 23 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor xfodev; Gittensor profile; 56 PR(s), 0 issue(s).
Improvement ℹ️ None detected risk: low · value: none · LLM: minor
Linked issue satisfaction

Addressed
The diff rewrites all four flagged locations (lines 1-11 header, the mirrors-sentry.ts sentence, the redaction-rules literal-copy comment, and the tagValue v8-ignore note) to past tense, removes parallel-run/#8298 framing, and states PostHog fully replaced Sentry, consistent with review-enrichment's wording while retaining discovery-index-specific deploy details.

Review context
  • Author: xfodev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: JavaScript, TypeScript
  • Official Gittensor activity: 56 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Add validation command/output.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit e62f6f1 into JSONbored:main Jul 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

discovery-index/src/posthog.ts header comment still describes a parallel-run with a deleted sentry.ts

1 participant