fix(selfhost): list globalThis-cast and dual-arg severity env vars in the reference (#8627)

[RealDiligent]

Problem

Closes #8627.

The self-host env-reference generator (scripts/gen-selfhost-env-reference.ts) failed to list three PostHog env vars that src/selfhost/posthog.ts actually reads:

• POSTHOG_SERVER_NAME — read at posthog.ts:179 via (globalThis as unknown as {...}).process?.env?.POSTHOG_SERVER_NAME. The .env base here is a .process property access, not a bare process/env identifier, so isEnvContainer walked past it.
• POSTHOG_MIN_SEVERITY / POSTHOG_REPO_MIN_SEVERITY — passed as two name literals to resolveSeverityThreshold(env, repo, "POSTHOG_MIN_SEVERITY", "POSTHOG_REPO_MIN_SEVERITY") at posthog.ts:81. The literal-arg helper map only supported a single argument index.

Fix

• isEnvContainer: recognize globalThis.process(.env) (through casts/parens) as an env container, via a small isGlobalThisProcess helper. Generalized — not special-cased to the one literal.
• ENV_NAME_LITERAL_ARG_HELPERS: carry multiple literal-name arg indices per helper, and register resolveSeverityThreshold at args [2, 3]. isEnvNameLiteralArgHelperCall and the collect handler now iterate all configured indices.

Because the helper fix is general, it also correctly surfaces PAGERDUTY_MIN_SEVERITY / PAGERDUTY_REPO_MIN_SEVERITY (src/services/notify-pagerduty.ts:103, the same helper) — these were missing for the identical reason. The regenerated reference now lists all five, each attributed to its real source file.

Tests

• Two regression tests in test/unit/selfhost-env-reference-script.test.ts (globalThis-cast read; dual-literal resolveSeverityThreshold). Reverting either fix fails its test.
• npm run selfhost:env-reference -- --check passes with the regenerated reference committed.
• Full existing suite for the generator (8 tests) passes.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.77%. Comparing base (b471ee1) to head (6dd3676).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8634   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files         798      798           
  Lines       79464    79464           
  Branches    24078    24078           
=======================================
  Hits        73725    73725           
  Misses       4592     4592           
  Partials     1147     1147           

Flag	Coverage Δ
backend	93.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[loopover-orb]

Caution

🛑 LoopOver review result - reject/close recommended

_{Review updated: 2026-07-25 16:14:55 UTC}

3 files · 1 AI reviewer · 1 blocker · CI green · dirty

🛑 Suggested Action - Reject/Close

Review summary
This PR generalizes the self-host env-reference generator to recognize globalThis-cast process.env reads and multi-arg literal-name helper calls, fixing the root cause (isEnvContainer / ENV_NAME_LITERAL_ARG_HELPERS) rather than special-casing the three PostHog vars from #8627. As a bonus, the fix correctly surfaces two previously-missed PagerDuty severity vars via the same shared resolveSeverityThreshold helper. The regenerated reference file and two new regression tests match the code changes, and the trace from posthog.ts's actual read patterns to the generator logic is accurate and verifiable in the visible diff.

Nits — 3 non-blocking

• scripts/gen-selfhost-env-reference.ts:126 — the external brief flags a 'magic number 3' but this is a false read of the array literal `[2, 3]` for resolveSeverityThreshold's arg indices, which is already well-commented; no action needed.
• The generated selfhost-env-reference.ts file is large (~686 lines) but it's a generated artifact per its own header comment, so file-length is not a meaningful maintainability concern here.
• Consider whether isGlobalThisProcess should also match the historical `env` container check the same way `process`/`c` do today, in case other files use a globalThis-cast `env` (not `process.env`) shape — not required by this PR's scope.

Why this is blocked

• No linked issue detected: The PR cites an issue number, but it could not be verified as a currently open issue. — If this PR is intended to solve an issue, link it explicitly in the PR body.

📋 Copy for AI agents — paste into your coding agent

Fix the following blocker(s) from this PR review:

1. No linked issue detected: The PR cites an issue number, but it could not be verified as a currently open issue. — If this PR is intended to solve an issue, link it explicitly in the PR body.

Decision drivers

• ❌ Code review — 1 blocker (1 reviewer)
• ❌ Gate result — Blocking (Repo-configured hard blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#8627
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 342 registered-repo PR(s), 143 merged, 37 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	RealDiligent; Gittensor profile; 342 PR(s), 37 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The PR generalizes isEnvContainer to recognize the globalThis-cast process.env shape used by POSTHOG_SERVER_NAME and extends ENV_NAME_LITERAL_ARG_HELPERS to support multi-index literal args for resolveSeverityThreshold, capturing POSTHOG_MIN_SEVERITY and POSTHOG_REPO_MIN_SEVERITY, with new unit tests and a regenerated reference file showing exactly the three PostHog vars added plus related PagerDu

Review context

• Author: RealDiligent
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: Python, Ruby, TypeScript, Svelte, Cuda, JavaScript, Markdown, MDX
• Official Gittensor activity: 342 PR(s), 37 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review

[loopover-orb]

LoopOver is closing this pull request on the maintainer's behalf (conflicts with the base branch — resolve and open a fresh PR; No linked issue detected). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.