Skip to content

docs(contributing-skill): align CI job-structure table with unsharded validate jobs - #8750

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
philluiz2323:docs/8692-ci-job-structure-reference
Jul 26, 2026
Merged

docs(contributing-skill): align CI job-structure table with unsharded validate jobs#8750
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
philluiz2323:docs/8692-ci-job-structure-reference

Conversation

@philluiz2323

Copy link
Copy Markdown
Contributor

Summary

  • Rewrite .claude/skills/contributing-to-loopover/reference.md's CI section so the Actions UI job names (changes, validate-code, validate-tests, validate) are primary.
  • Map historical check labels (lint, test (1/3..3/3), workers, mcp, ui, …) as steps inside those jobs after the 2026-07-24 unsharding consolidation.
  • Cite the matching .github/workflows/ci.yml line numbers for each job/step mapping.

Closes #8692

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • Cross-checked rewritten table against ci.yml (cited lines):
    • Jobs: changes L27, validate-code L258, validate-tests L829 (UNSHARDED note L843), validate L1154 / needs L1156
    • Representative steps: Check whitespace L78; Lint workflows L286; Typecheck L510; Worker runtime tests L525; Build MCP L541; MCP package check L544; Build miner CLI L563; Miner package check L571; Test with coverage L950; UI lint/typecheck/tests/build L762/L765/L778/L781/L792; Docs drift L355; etc.
  • npm run actionlint — not applicable (docs-only; no workflow edits)
  • npm run typecheck — not applicable
  • npm run test:coverage — not applicable (documentation-only; no runtime/coverage surface)
  • npm run test:workers — not applicable
  • npm run build:mcp — not applicable
  • npm run test:mcp-pack — not applicable
  • npm run ui:openapi:check — not applicable
  • npm run ui:lint — not applicable
  • npm run ui:typecheck — not applicable
  • npm run ui:build — not applicable
  • npm audit --audit-level=moderate — not applicable
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Documentation-only fix per issue Test Coverage Requirements; verification is the ci.yml line-number cross-check above (also required by the issue Deliverables).

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

Not applicable — contributing-skill reference docs only; no visible UI changes.

Notes

… validate jobs

Rewrite reference.md so contributors see the real Actions jobs (changes, validate-code, validate-tests, validate) with historical check names mapped as steps, citing ci.yml line numbers after the 2026-07-24 unsharding.

Closes #8692
@philluiz2323
philluiz2323 requested a review from JSONbored as a code owner July 26, 2026 02:36
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:priority Maintainer-selected Gittensor priority — scores a 1.5x multiplier. labels Jul 26, 2026
@loopover-orb

loopover-orb Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-26 02:41:07 UTC

1 file · 1 AI reviewer · no blockers · readiness 95/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a docs-only rewrite of the internal contributing-skill reference table to reflect a 2026-07-24 CI unsharding, replacing former top-level job names (lint, test 1/3..3/3, workers, mcp, ui) with the current Actions UI job names (changes, validate-code, validate-tests, validate) and citing specific ci.yml line numbers for each mapping. The diff is internally consistent, closes issue #8692, is docs-only (no runtime/coverage surface), and all CI checks pass. The change is well-scoped and matches its stated intent — a maintenance/accuracy update to a reference doc rather than new feature surface.

Nits — 5 non-blocking
  • The line-number citations (e.g. L286, L510, L950) are a maintenance liability since they will silently drift the next time ci.yml is edited, with no mechanical drift check tying this doc to the workflow file the way docs:drift-check does for other docs.
  • The 'coverage bolt-on filenames' row now says 'local / npm run test:ci (not a named CI step)' but doesn't clarify whether this still runs in the validate-tests job or is purely local-only, which is a slight ambiguity versus the rest of the table's job-anchored format.
  • Consider whether `npm run docs:drift-check` (mentioned elsewhere in this same file) could be extended to cover this table's ci.yml line citations, so future workflow edits don't silently stale this reference.
  • A brief note on when the line numbers were last verified (e.g. commit SHA or date) would help future readers judge staleness risk at a glance.
  • Diff looks like trivial or whitespace-only churn — Reduce whitespace-only or formatting-only churn and keep the diff focused on substantive changes.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8692
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 1025 registered-repo PR(s), 601 merged, 126 issue(s).
Contributor context ✅ Confirmed Gittensor contributor philluiz2323; Gittensor profile; 1025 PR(s), 126 issue(s).
Improvement ℹ️ Insufficient signal risk: low · value: insufficient-signal · LLM: moderate
Linked issue satisfaction

Addressed
The diff rewrites reference.md's CI table to list the real jobs (changes, validate-code, validate-tests, validate) and maps every previously-listed check as a step within its correct parent job, matching the issue's exact requirements.

Review context
  • Author: philluiz2323
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, JavaScript, MDX, TypeScript, CSS, Cuda, HTML, Kotlin
  • Official Gittensor activity: 1025 PR(s), 126 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Triage stale or unlinked PRs.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit d300731 into JSONbored:main Jul 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. gittensor:priority Maintainer-selected Gittensor priority — scores a 1.5x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs(contributing-skill): reference.md's CI job-structure table is stale after the 2026-07-24 unsharding consolidation

1 participant