fix(ui): point roadmap owner-console card at the dedicated /app/owner route - #8799
Merged
JSONbored merged 2 commits intoJul 26, 2026
Merged
Conversation
… route The "Phase 3: repo owner intake console" card linked to /app/repos, which defaults to the Maintainer console tab when no search param is given -- the opposite surface from what the card describes. Every other phase already links to its own dedicated route; this does the same for Phase 3. Closes JSONbored#8669
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
JSONbored
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/app/repos, which defaults to the Maintainer console tab when nosearchparam is given (app.repos.tsx:27) — the opposite surface from what the card describes. Every other phase links to its own dedicated route; this points Phase 3 at its dedicated route,/app/owner, the same way.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlint— skipped, no.github/workflows/composite-action changes.npm run typecheck(vianpm run ui:typecheck— clean)npm run test:coveragelocally —apps/**is excluded fromcodecov/patchgating (confirmed againstvitest.config.ts/codecov.yml). Ran the applicable equivalent:npx vitest run src/routes/roadmap.test.tsx(2/2 passed) and the fullnpm run ui:test(630/630 + 407/407 passed across@loopover/ui+@loopover/ui-miner).npm run test:workers— skipped, no Workers/backend code touched.npm run build:mcp— skipped, no MCP package changes.npm run test:mcp-pack— skipped, no MCP package changes.npm run ui:openapi:check— skipped, no API/OpenAPI schema changes.npm run ui:lint— 0 errors (11 pre-existingreact-refresh/only-export-componentswarnings across the codebase, same pre-existing pattern already present elsewhere; unrelated to this diff).npm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderate— 5 pre-existing high-severity advisories in theeslint/minimatch/brace-expansiondev-dependency chain, unrelated to this change (zero new dependencies added).roadmap.test.tsxasserts the actual resolved link destination (not just link presence), plus a sibling regression guard that Phase 2's link is untouched.If any required check was skipped, explain why:
test:workers/test:mcp-pack/ui:openapi:check/actionlintall skipped as not applicable — this diff touches exactly two files underapps/loopover-ui/src/routes/, nothing else.Safety
hreftarget only, no data-fetching behavior.UI Evidencesection below with screenshots. — see below; no screenshots needed for this specific change, with reasoning given.UI Evidence
This change only redirects a link's destination (
to: "/app/repos"→to: "/app/owner"); the card's rendered text, layout, color, and position are unchanged. Freshly captured this submission, running the real app locally against/roadmap(a public route, no auth/mocking needed).apps/loopover-uiis a dark-mode-only build (theme toggle removed —apps/loopover-ui/src/components/site/theme-toggle.tsx), so Dark is the only theme this app has.Before and after are the identical image in every row, intentionally — the fix changes only an anchor's
href, not anything rendered, so a genuine before/after comparison shows no visual difference.Notes
/app/owner), matching the pattern of every other phase, per the issue's stated preference; (2) no other phase'sLINK_MAPentry was touched, verified by a sibling regression test asserting Phase 2's link is unchanged.