Skip to content

Reactivation of org.openrewrite.staticanalysis.RemoveRedundantTypeCast #12828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

koppor
Copy link
Member

@koppor koppor commented Mar 26, 2025

Refs openrewrite/rewrite-static-analysis#221

  1. Wait for a new release of https://github.com/openrewrite/rewrite-recipe-bom
  2. Try out release here
  3. If it works: merge
  4. If it not works: Open an issue at https://github.com/openrewrite/rewrite-static-analysis/issues/

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • [/] Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr closed this Apr 9, 2025
@Siedlerchr Siedlerchr reopened this Apr 9, 2025
@Siedlerchr Siedlerchr marked this pull request as ready for review April 9, 2025 19:24
@@ -423,7 +423,7 @@ void getUsedStringsSingleString() {
database.addString(tripleB);
database.insertEntry(entry);

List<BibtexString> usedStrings = (List<BibtexString>) database.getUsedStrings(Collections.singletonList(entry));
List<BibtexString> usedStrings = database.getUsedStrings(Collections.singletonList(entry));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch removes an unnecessary type cast, which is a positive change. However, the special instructions require the use of modern Java data structures, such as Set.of() instead of new HashSet<>(Arrays.asList(...)).

Copy link
Contributor

github-actions bot commented Apr 9, 2025

The build of this PR is available at https://builds.jabref.org/pull/12828/merge.

@Siedlerchr
Copy link
Member

Still broken. Commented ont hat issue

@Siedlerchr Siedlerchr marked this pull request as draft April 9, 2025 19:35
@JabRef JabRef deleted a comment from trag-bot bot Apr 21, 2025
@JabRef JabRef deleted a comment from trag-bot bot Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants