Skip to content

Disable non-working tets (with issue links) #12868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@
import org.jabref.testutils.category.FetcherTest;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;

@FetcherTest
@Disabled("See https://github.com/JabRef/jabref/issues/12864")
class ApsFetcherTest {

private ApsFetcher finder;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import org.jabref.testutils.category.FetcherTest;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.mockito.Answers;

Expand All @@ -25,6 +26,7 @@
import static org.mockito.Mockito.when;

@FetcherTest
@Disabled("https://github.com/JabRef/jabref-issue-melting-pot/issues/843")
public class AstrophysicsDataSystemTest implements PagedSearchFetcherTest {

private AstrophysicsDataSystem fetcher;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import kong.unirest.core.json.JSONObject;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
Expand All @@ -26,6 +27,7 @@
import static org.mockito.Mockito.when;

@FetcherTest
@Disabled("https://github.com/JabRef/jabref-issue-melting-pot/issues/844")
class BiodiversityLibraryTest {
private final String RESPONSE_FORMAT = "&format=json";

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import static org.mockito.Mockito.when;

@FetcherTest
@Disabled("https://github.com/JabRef/jabref-issue-melting-pot/issues/846")
class IEEETest implements SearchBasedFetcherCapabilityTest, PagedSearchFetcherTest {

private static ImportFormatPreferences importFormatPreferences;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,12 @@ void searchByEmptyQueryFindsNothing() throws Exception {
public void supportsYearSearch() {
}

@Test
@Override
@Disabled("Results returned contain a few incorrect years. The majority are accurate")
public void supportsYearRangeSearch() {
}

@Override
public PagedSearchBasedFetcher getPagedFetcher() {
return fetcher;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ default void supportsYearRangeSearch() throws Exception {
List<String> yearsInYearRange = List.of("2018", "2019", "2020");

List<BibEntry> result = getFetcher().performSearch("year-range:2018-2020");
assertFalse(result.isEmpty());

FieldPreferences fieldPreferences = mock(FieldPreferences.class);
when(fieldPreferences.getNonWrappableFields()).thenReturn(FXCollections.observableArrayList());
ImportCleanup.targeting(BibDatabaseMode.BIBTEX, fieldPreferences).doPostCleanup(result);
Expand All @@ -88,8 +90,8 @@ default void supportsYearRangeSearch() throws Exception {
.filter(Optional::isPresent)
.map(Optional::get)
.distinct()
.collect(Collectors.toList());
assertFalse(result.isEmpty());
.toList();

assertTrue(yearsInYearRange.containsAll(differentYearsInResult));
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,14 @@

import org.apache.hc.core5.net.URIBuilder;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;

@FetcherTest
@Disabled("https://github.com/jabref/jabref/issues/10257")
class ACMPortalParserTest {

ACMPortalParser parser;
Expand Down