-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Column Check for Bibtex Parser #12949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
JUnit tests are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Unit tests (pull_request)" and click on it. You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide. |
@Zurtar Please add a test case for the issue addressed. At first sight, the fix looks good. Changelog should be "Changed" section as jabrefs behavior changed |
Your pull request conflicts with the target branch. Please merge |
if (col > 1) { | ||
continue; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic here does not follow the fail-fast principle. It should return early if the condition is not met, rather than using 'continue'.
Closes #12929
Added a column counter and check for Bibtex parsing.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if change is visible to the user)