Skip to content

Web Import: Add New Entries to 'Imported Entries' Group #12998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paudelritij
Copy link
Contributor

@paudelritij paudelritij commented Apr 25, 2025

Closes #12548
This PR introduce feature to add new group "Imported Entries"

To Do

  • Link preferences configuration to BibEntry (for enable/disable and name of group)
  • Configure Meta data for imported entries group
  • Introduce Smart Group 1 SmartGroup:Import entries\
  • [?] Create library-specific settings for particular imported entries group for name and disable/enable option
  • Add test cases

Done

  • Add configurable field for Imported entries group in preferences
  • Create fields for Import entries group in library preferences

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [.] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [.] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [.] Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Comment on lines +36 to +37
@FXML private CheckBox addImportedEntries;
@FXML private TextField addImportedEntriesGroupName;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new UI elements 'addImportedEntries' and 'addImportedEntriesGroupName' should have their labels localized using Localization.lang to support multilingual functionality.

@jabref-machine
Copy link
Collaborator

JUnit tests are failing. You can see which checks are failing by locating the box "Some checks were not successful" on the pull request page. To see the test output, locate "Tests / Unit tests (pull_request)" and click on it.

You can then run these tests in IntelliJ to reproduce the failing tests locally. We offer a quick test running howto in the section Final build system checks in our setup guide.

@jabref-machine
Copy link
Collaborator

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of [x] (done), [ ] (not done yet) or [/] (not applicable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web import: New entry should be added to group "Imported entries"
2 participants