Issue676 author last

[espertusnu]

Addresses JabRef#676

• Moves tests of lastAuthor from CitationKeyGeneratorTest to BracketedPatternTest
• Fixes a link from javadoc to documentation
• Reorders methods in BracketedPatternTest so argument providers consistently appear before tests using them

I made these changes as preparation for a class session in mid-September where I will demonstrate how to make a change and PR. It would be easiest for me if this is reviewed but not merged; however, if it is easier for you to merge once approved, I can create a pre-merge branch for the class demonstration.

The first commit message has a typo; it should be "Add test of [authLast]".

Steps to test

Rerun the tests in logic/citationkeypattern.

Mandatory checks

• I own the copyright of the code submitted and I license it under the MIT license
• [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
• Tests created for changes (if applicable)
• [/] Manually tested changed features in running JabRef (always required)
• [/] Screenshots added in PR description (if change is visible to the user)
• [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[koppor]

Tests are failing due to missing dependencies:

Could not determine the dependencies of task ':jabls:checkstyleMain'.
> Could not resolve all dependencies for configuration ':jabls:compileClasspath'.
   > Could not resolve com.google.code.gson:gson:[2.9.1,3.0).
     Required by:
         project :jabls > com.github.eclipse:lsp4j:0.24.0 > com.github.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc:0.24.0
         project :jabls > com.github.eclipse:lsp4j:0.24.0 > com.github.eclipse.lsp4j:org.eclipse.lsp4j.jsonrpc.debug:0.24.0
      > Failed to list versions for com.google.code.gson:gson.
         > Unable to load Maven meta-data from https://oss.sonatype.org/content/groups/public/com/google/code/gson/gson/maven-metadata.xml.
            > Could not GET 'https://oss.sonatype.org/content/groups/public/com/google/code/gson/gson/maven-metadata.xml'.
               > Read timed out

[koppor]

Note that not all tasks from JabRef#676 are adressed, but I think, this is on purpose :)

[Siedlerchr]

oss sonatype is down

[espertusnu]

Note that not all tasks from JabRef#676 are adressed, but I think, this is on purpose :)

Correct. You can close this PR when it's a good model for my students.

[jabref-machine]

Note that your PR will not be reviewed/accepted until you have gone through the mandatory checks in the description and marked each of them them exactly in the format of [x] (done), [ ] (not done yet) or [/] (not applicable).

[trag-bot]

@trag-bot didn't find any issues in the code! ✅✨