bugfix: Fix brightness control on non-English Windows by using alias-… #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…based GUID lookup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code relied on language-specific output from
powercfg -qto extract the GUIDs for the current power scheme, display subgroup, and brightness setting. This approach failed on Windows systems using non-English languages due to localized descriptions (e.g.,(Display)or(Display brightness)not matching).This fix:
powercfg /getactiveschemeto reliably obtain the active power scheme GUID.powercfg -aliasescombined withfindstrto extract the GUIDs forSUB_VIDEOandVIDEONORMALLEVELaliases.