docs(crews): say why a preview goes stale and why ACP seats lack auto modes - #307
bryantderosier wants to merge 2 commits into
Conversation
… modes Two correct behaviors at the roster gate surprised a person the first time. The approval preview binds the Captain's branch and worktree, so a branch switch between preview and approval failed with "preview has changed" and nothing said why. And the seat editor hides Accept edits and Auto on ACP registry harnesses, which cannot enforce them, with no explanation. crews.md AC3 and the Crews section of the personas guide now say both, and the stale-preview refusal names the roster, a seat's runtime, and the Captain's branch or worktree as what may have changed. Message text only; no behavior change. Closes #231 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: Jacksondr5/j5code/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Comment |
Conflict in crews.md History: kept this branch's AC3 entry beside the sync's handoff artifact entry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
[Review panel: Opus 5.5 + coordinator (Opus 5.5)] Rebase needed. The Docs: the new crews.md History line has no attribution, while every other line names who decided and links a record; suggest "(Bryant; #231)". It also sits after the out-of-order 2026-09-16 line. Once #306 restores date order, it belongs with the other 2026-09-24 lines. |
|
Decision (Jackson, 2026-09-26): use upstream's access-mode names everywhere. Upstream's composer labels the modes Supervised, Auto-accept edits, Auto and Full access. J5's copies say "Approval required" and "Accept edits". Please fold the rename into this PR, since it's the same topic:
|
Problem
Two correct behaviors at the roster gate surprised a person the first time (#231). The approval preview token binds the Captain's project, branch, worktree, and interaction mode (
crewRuntimePreview.ts), so switching the Captain's branch between preview and approval failed with "preview has changed" and nothing said why. And seats on an ACP registry harness can't use Accept edits or Auto, because the harness can't enforce them, but the seat editor hid those options without explanation.What I changed
docs/j5/product/features/crews.mdAC3: one sentence that the preview binds the Captain's project, branch, worktree, and interaction mode, plus a History line.docs/user/personas.md, Crews section: one sentence each for the branch binding and the missing access modes on ACP harnesses.apps/server/src/j5/a2a/CrewProposalService.ts: the stale-preview refusal names the roster, a seat's runtime, and the Captain's branch or worktree as what may have changed. Message text only.Why this shape
The binding is correct: approval must launch exactly what was shown. So the fix is saying why, in the card message the person already sees and in the docs, not changing the behavior.
Invariants
Surfaces
packages/contracts)docs/user/personas.md.Out of scope
Upgrade and data
None.
Verification
CrewProposalService.test.ts: 15 passed. No test pins the message text, and I didn't add one that would only mirror the string.Review focus
Closes #231
Claude Opus 5.5 via Claude Code
🤖 Generated with Claude Code