Skip to content

testID added #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
max-kim wants to merge 3 commits into
base: master
Choose a base branch
from
Open

testID added #154

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6477b2
testID added
Dec 2, 2019
107c46e
fixed JSX
Dec 2, 2019
5f8e29b
Update AppIntroSlider.js
max-kim Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions AppIntroSlider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export default class AppIntroSlider extends React.Component {
paginationStyle: null,
showDoneButton: true,
showNextButton: true,
testId: testID => ({ testID }),
};
state = {
width,
Expand Down Expand Up @@ -117,13 +118,15 @@ export default class AppIntroSlider extends React.Component {
};

_renderOuterButton = (content, name, onPress) => {
const { testId } = this.props;
const style =
name === 'Skip' || name === 'Prev' ? styles.leftButtonContainer : styles.rightButtonContainer;
return (
<View style={!this.props.bottomButton && style}>
<TouchableOpacity
onPress={onPress}
style={this.props.bottomButton ? styles.flexOne : this.props.buttonStyle}
{...testId(`button_${name}`)}
>
{content}
</TouchableOpacity>
Expand Down Expand Up @@ -151,6 +154,8 @@ export default class AppIntroSlider extends React.Component {
(!isFirstSlide && this._renderPrevButton()) || (!isLastSlide && this._renderSkipButton());
const btn = isLastSlide ? this._renderDoneButton() : this._renderNextButton();

const { testId } = this.props;

return (
<View style={[styles.paginationContainer, this.props.paginationStyle]}>
<View style={styles.paginationDots}>
Expand All @@ -165,6 +170,7 @@ export default class AppIntroSlider extends React.Component {
: this.props.dotStyle,
]}
onPress={() => this._onPaginationPress(i)}
{...testId(`page_${i}`)}
/>
))}
</View>
Expand Down