Support Task Configuration Avoidance #1445
Conversation
| @@ -1,2 +1 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| package="butterknife"/> | |||
| <manifest package="butterknife.core"/> | |||
There was a problem hiding this comment.
This was a side effect of upgrading the AGP version, it looks like single word package names are not allowed anymore. But I don't think it has any impact.
There was a problem hiding this comment.
There was a problem hiding this comment.
What is the impact of the change of the manifest ?
stephanenicolas
force-pushed
the
sni/issue-1440-use-lazy-tasks
branch
from
9913d77 to
4387cf1
Compare
| @@ -6,15 +6,14 @@ buildscript { | |||
| 'compileSdk': 28, | |||
|
|
|||
| 'androidTools': '26.2.0', | |||
| 'kotlin': '1.2.71', | |||
|
|
|||
| 'kotlin': '1.3.11', | |||
There was a problem hiding this comment.
this version of kotlin is not the latest, but it is recommended in AS 3.3.0 that goes with AGP 3.3.0
|
The PR has been rebased against current master, I squashed my commits, it should now get green. The kotlin version better matches Android Studio. |
|
I just realized I was missing an obsolete call. I fixed it in a second commit. Please test it properly or let me know how to make sure the original behavior works fine. |
|
I've tested the second commit too and all seems to be working pretty well. |
Solves issue #1440. The change is limited.