Add ranking freeze feature #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -173,25 +177,53 @@ const solves = async (request, response) => { | |||
| }; | |||
|
|
|||
| const ranking = async (request, response) => { | |||
| const dbRes = await pool.query( | |||
There was a problem hiding this comment.
I mean, you could just disable the submissions after some timestamp instead of filtering the ranking.
Also, I think that the freeze == 'true' check does nothing, the entire if statement is redundant and not required.
You could just remove it and always filter by the timestamp. The result would be functionally the same.
There was a problem hiding this comment.
if statement is redundant, because freeze ha wrong value by mistake
| @@ -12,6 +12,6 @@ COPY ./competition.yaml /etc/sok/ | |||
|
|
|||
| ENV SOK_CONFIG=/etc/sok/competition.yaml | |||
|
|
|||
| EXPOSE 8080 | |||
There was a problem hiding this comment.
Remind me to change the reverse proxy config right before merging this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.