6 - #4
Conversation
pumanitro
left a comment
pumanitro
left a comment
There was a problem hiding this comment.
Few comments about 6'th task.
| <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.7.2/css/all.css" integrity="sha384-fnmOCqbTlWIlj8LyTjo7mOUStjsKC4pOpQbqyi7RrhN7udi9RwhKkMHpvLbHG9Sr" crossorigin="anonymous"> | ||
| </head> | ||
| <body> | ||
| <div class="blacksmile"> |
There was a problem hiding this comment.
Why do we need that div?
| <div class="blacksmile"> | ||
| <i class="fas fa-smile"> </i> | ||
| </div> | ||
| <div class="ytbutton"> |
There was a problem hiding this comment.
Use Hyphen Delimited Strings for class names.
Please read just "Use Hyphen Delimited Strings" section from here:
https://medium.freecodecamp.org/css-naming-conventions-that-will-save-you-hours-of-debugging-35cea737d849
| height: 200px; | ||
| margin-bottom: 30px; | ||
| } | ||
| .fa-smile { |
There was a problem hiding this comment.
Try to omit as much as possible styling for third party library classes.
It means leave .fa-smilte class, untouched and try to style this smile by creating your own class like black-smile.
Why we shouldn't change styling for .fa-smile class?
| background-color: #d7d7d7; | ||
| margin-bottom: 30px; | ||
| } | ||
| .fa-youtube { |
There was a problem hiding this comment.
What is the point of that class (fa-youtube)?
| box-sizing: border-box; | ||
| } | ||
|
|
||
| .fa-camera-retro { |
There was a problem hiding this comment.
As above, please don't change third-party classes behaviors.
Just create own class and use it it given case.
| @@ -0,0 +1 @@ | |||
| <svg aria-hidden="true" focusable="false" data-prefix="fas" data-icon="camera-retro" class="svg-inline--fa fa-camera-retro fa-w-16" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"><path fill="#81DB79" d="M48 32C21.5 32 0 53.5 0 80v352c0 26.5 21.5 48 48 48h416c26.5 0 48-21.5 48-48V80c0-26.5-21.5-48-48-48H48zm0 32h106c3.3 0 6 2.7 6 6v20c0 3.3-2.7 6-6 6H38c-3.3 0-6-2.7-6-6V80c0-8.8 7.2-16 16-16zm426 96H38c-3.3 0-6-2.7-6-6v-36c0-3.3 2.7-6 6-6h138l30.2-45.3c1.1-1.7 3-2.7 5-2.7H464c8.8 0 16 7.2 16 16v74c0 3.3-2.7 6-6 6zM256 424c-66.2 0-120-53.8-120-120s53.8-120 120-120 120 53.8 120 120-53.8 120-120 120zm0-208c-48.5 0-88 39.5-88 88s39.5 88 88 88 88-39.5 88-88-39.5-88-88-88zm-48 104c-8.8 0-16-7.2-16-16 0-35.3 28.7-64 64-64 8.8 0 16 7.2 16 16s-7.2 16-16 16c-17.6 0-32 14.4-32 32 0 8.8-7.2 16-16 16z"></path></svg> No newline at end of file | |||
There was a problem hiding this comment.
Why do we need this file on repository?
| @@ -0,0 +1 @@ | |||
| <svg aria-hidden="true" data-prefix="fab" data-icon="youtube" class="svg-inline--fa fa-youtube fa-w-18" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 576 512"><path fill="#DE0000" d="M549.655 124.083c-6.281-23.65-24.787-42.276-48.284-48.597C458.781 64 288 64 288 64S117.22 64 74.629 75.486c-23.497 6.322-42.003 24.947-48.284 48.597-11.412 42.867-11.412 132.305-11.412 132.305s0 89.438 11.412 132.305c6.281 23.65 24.787 41.5 48.284 47.821C117.22 448 288 448 288 448s170.78 0 213.371-11.486c23.497-6.321 42.003-24.171 48.284-47.821 11.412-42.867 11.412-132.305 11.412-132.305s0-89.438-11.412-132.305zm-317.51 213.508V175.185l142.739 81.205-142.739 81.201z"/></svg> No newline at end of file | |||
There was a problem hiding this comment.
Why do we need this file on repository?
2 participants
No description provided.