-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement namespace declarations #241
Merged
Merged
+944
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only integration-tests left now
Almost done. Missing: stream API (maybe do it in a separate PR?) and RIOT/Rio tests with stuff like serializing a whole dataset / graph. It's hard to test this sensibly in integration-tests, because there are too many different APIs to work with...
Ostrzyciel
commented
Dec 21, 2024
core/src/main/scala/eu/ostrzyciel/jelly/core/ConverterFactory.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/eu/ostrzyciel/jelly/core/ProtoDecoderConverter.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/eu/ostrzyciel/jelly/core/helpers/MockConverterFactory.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/eu/ostrzyciel/jelly/core/helpers/MockProtoDecoderConverter.scala
Outdated
Show resolved
Hide resolved
jena/src/main/scala/eu/ostrzyciel/jelly/convert/jena/JenaConverterFactory.scala
Outdated
Show resolved
Hide resolved
jena/src/test/scala/eu/ostrzyciel/jelly/convert/jena/JenaDecoderConverterSpec.scala
Outdated
Show resolved
Hide resolved
rdf4j/src/main/scala/eu/ostrzyciel/jelly/convert/rdf4j/Rdf4jConverterFactory.scala
Outdated
Show resolved
Hide resolved
rdf4j/src/main/scala/eu/ostrzyciel/jelly/convert/rdf4j/Rdf4jConverterFactory.scala
Outdated
Show resolved
Hide resolved
code looks good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the new Jelly 1.1.0 feature, namespace declarations: Jelly-RDF/jelly-protobuf#12
Implemented: core API, Jena & RDF4J implementation, Jena RIOT & RDF4J Rio integrations, integration tests.
Not implemented: Pekko Streams API. This can be tackled in a separate PR.
This is implemented according to the compatibility notes in the original issue: