Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoqPilot refinement: Grazie bug fix, new limiting context model parameters, unsafe code refactor #55

Merged
merged 9 commits into from
Jan 29, 2025

Conversation

GlebSolovev
Copy link
Collaborator

@GlebSolovev GlebSolovev commented Jan 17, 2025

  • 🐞 Fixed GrazieService bug. Resolved an issue where it generated choices + 1 proofs instead of the expected choices. This was caused by an improperly updated loop after a prior refactor.

  • 🆕 Added and tested new model parameters. Introduced maxContextTheoremsNumber and multiroundProfile.maxPreviousProofVersionsNumber to better control the context sent to LLMs.

    • Previously, users could only limit the context by adjusting tokensToGenerate, but these new parameters provide a more intuitive and precise way to manage it.
    • These additions are essential for experiments exploring how premises influence CoqPilot's proof generation capabilities.
  • 💂‍♂️ Refactored potentially unsafe code:

    • In the project's early stages, we (or at least I) sometimes used misleading as type casts without realizing they only perform compile-time checks and have no effect at runtime. These cases have now been reviewed, and misleading casts were replaced with proper runtime checks or refactored entirely.
    • Updated constructors for all custom errors to ensure consistent and reliable typing in all scenarios, following the approach established in the last benchmarking framework refactor.
    • Revised and refactored error-throwing code: replaced most of the generic Error-s with more specific ones using previously introduced error-utils wrappers.

@GlebSolovev GlebSolovev self-assigned this Jan 17, 2025
Base automatically changed from benchmarking-multiround to v2.5.0-dev January 29, 2025 11:58
@GlebSolovev
Copy link
Collaborator Author

Ran CI manually, it passes: https://github.com/JetBrains-Research/coqpilot/actions/runs/13030842228

@GlebSolovev GlebSolovev merged commit 6351238 into v2.5.0-dev Jan 29, 2025
3 checks passed
@GlebSolovev GlebSolovev deleted the coqpilot-refinement branch January 29, 2025 13:04
@K-dizzled K-dizzled self-requested a review January 29, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant