CoqPilot refinement: Grazie bug fix, new limiting context model parameters, unsafe code refactor #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐞 Fixed
GrazieService
bug. Resolved an issue where it generatedchoices + 1
proofs instead of the expectedchoices
. This was caused by an improperly updated loop after a prior refactor.🆕 Added and tested new model parameters. Introduced
maxContextTheoremsNumber
andmultiroundProfile.maxPreviousProofVersionsNumber
to better control the context sent to LLMs.tokensToGenerate
, but these new parameters provide a more intuitive and precise way to manage it.💂♂️ Refactored potentially unsafe code:
as
type casts without realizing they only perform compile-time checks and have no effect at runtime. These cases have now been reviewed, and misleading casts were replaced with proper runtime checks or refactored entirely.Error
-s with more specific ones using previously introduced error-utils wrappers.