Skip to content

Remove JetSnack sample in favor of JetCaster#5511

Merged
kropp merged 1 commit into
masterfrom
remove-jetsnack
Jan 14, 2026
Merged

Remove JetSnack sample in favor of JetCaster#5511
kropp merged 1 commit into
masterfrom
remove-jetsnack

Conversation

@kropp
Copy link
Copy Markdown
Member

@kropp kropp commented Jan 14, 2026

JetSnack sample is outdated and hard to maintain because of ConstraintLayout
Recently, there was another sample app ported from Jetpack samples to Multiplatform
https://github.com/kotlin-hands-on/jetcaster-kmp-migration

We don't need many similar samples, so let's keep the newer one only.

Fixes CMP-9404 Remove Jetsnack sample

Testing

N/A

Release Notes

N/A

@kropp kropp requested a review from eymar January 14, 2026 10:43
Copy link
Copy Markdown
Member

@eymar eymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about keeping the examples/jetsnack/README.md in case there some links to the project?
The readme can simple have a link to the new example?.

@kropp
Copy link
Copy Markdown
Member Author

kropp commented Jan 14, 2026

The only link I found is from https://github.com/Kotlin/kotlin-wasm-examples/blob/main/compose-jetsnack/README.md
Maybe we can remove it as well.

eymar added a commit to Kotlin/kotlin-wasm-examples that referenced this pull request Jan 14, 2026
This example is removed from the compose-multiplatform repo too

See JetBrains/compose-multiplatform#5511
Copy link
Copy Markdown
Member

@eymar eymar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kropp kropp merged commit f7af88d into master Jan 14, 2026
1 check passed
@kropp kropp deleted the remove-jetsnack branch January 14, 2026 11:58
@bashor
Copy link
Copy Markdown
Member

bashor commented Jan 14, 2026

As I see it, unlike JetSnack, JetCaster doesn't have non-mobile targets. Is it going to be changed? Should we keep JetSnack until then?

@kropp
Copy link
Copy Markdown
Member Author

kropp commented Jan 15, 2026

JetSnack in its current state isn't a good multiplatform sample, as it is very outdated. Updating it is not feasible, as original Android implementation has been changed significantly, like Material → Material3 transition and many internal things, and the non-Android part has been also significantly different from it because of ConstraintLayout.
That's beeing said the only viable option to have it up to date is to port it again from scratch, for which we don't have capacity now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants