[JEWEL-746] Load inline markdown images using Coil3

[obask]

It supports every image as an inline node

[obask]

currently there are 2 differences with a JCEF render: JCEF renders SVG as a giant image while we keep it small(I guess it just depends on a default size parameter), and the text in build|failing is not shown for some reason...

[rock3r]

They look like entirely different images... Are you sure it's the same image it's being displayed, and that it's loading correctly in the first case? That to me looks like a "broken image" placeholder (which also is way too big)

SVG files have an intrinsic size declared in their root node, and any renderer should adhere to that

[obask]

images I posted earlier are examples of how JCEF renders my "README.md" which this is how compose shows the same things:

README.md

[rock3r]

I see. I had misinterpreted the original message, sorry 🙏

The first image (the broken square) has a declared size of 800x800 px, encoded as width="800px" height="800px", which browsers seem to accept but maybe the Compose renderer doesn't like, and falls back to the viewBox size of 16x16. That would explain why it's larger on JCEF.

As for the latter, I think it's because the text for whatever reason just doesn't get rendered:

<g text-anchor="middle" font-family="DejaVu Sans,Verdana,Geneva,sans-serif" font-size="11">
    <use x="5.5" y="2" fill="#010101" fill-opacity=".3" href="#logo" />
    <use x="5.5" y="1" fill="#fff" href="#logo" />
  <text x="40.5" y="15" fill="#010101" fill-opacity=".3">build</text>
  <text x="40.5" y="14" fill="#fff">build</text>
  <text x="83.5" y="15" fill="#010101" fill-opacity=".3">passing</text>
  <text x="83.5" y="14" fill="#fff">passing</text>
</g>

Again, possibly some unsupported value in there that Skia ignores.

That's sort of weird since Skia can interpret image sizes with units, and render text — it does in Chrome! But maybe there is some setup that is missing, or Chrome does some magic stuff. Either way, these are either CMP or Skiko bugs :)

[obask]

This fixes both:

• Load images in Markdown jewel#472
• Add support for inline images in Markdown jewel#746

[obask]

The first image (the broken square) has a declared size of 800x800 px, encoded as width="800px" height="800px", which browsers seem to accept but maybe the Compose renderer doesn't like, and falls back to the viewBox size of 16x16. That would explain why it's larger on JCEF.

As for the latter, I think it's because the text for whatever reason just doesn't get rendered:

Again, possibly some unsupported value in there that Skia ignores.

I'm going to create a separate issue for SVG regressions. Should it go to youtrack?

[rock3r]

Should it go to youtrack?

Please, no. Stick with GH until further notice. You'll know together with everyone else when YT is usable. We're still waiting.

[rock3r]

Out of curiosity, have you filed the issues for SVG rendering?

I think the size one is caused by https://github.com/coil-kt/coil/blob/main/coil-svg/src/commonMain/kotlin/coil3/svg/SvgDecoder.kt#L39 this parameter being true by default. Ideally, users should be able to override the Coil loader with one they want, but we can keep it for a follow up (it'd be nice to have an issue tracking this in our YouTrack, if you can file it).

The text one is the more baffling one. If you can look into it, maybe you can figure out what is the cause, or at least where it should happen, and file an issue for that in the right place.

[rock3r]

@obask ping

[obask]

Out of curiosity, have you filed the issues for SVG rendering?

Thanks for doing initial investigation. I filed a tracking issue, but not the one in a coil repository yet.
https://youtrack.jetbrains.com/issue/JEWEL-762/Coil-image-rendering-issues-with-SVG

[obask]

ok, so IDEA dev(build from master) and the standalone sample works, but IDE sample uses an older version of the plarform:

2025-03-21 15:34:50,150 [ 148214]   WARN - #Jewel - AsyncImage loading: java.lang.NoSuchMethodError: 'kotlinx.coroutines.CoroutineDispatcher kotlinx.coroutines.CoroutineDispatcher.limitedParallelism$default(kotlinx.coroutines.CoroutineDispatcher, int, java.lang.String, int, java.lang.Object)'

So if we want to make it work in the sample, we have to add some small workaround there without affecting other modes.

[obask]

ok, so IDEA dev(build from master) and the standalone sample works, but IDE sample uses an older version of the platform:

@rock3r Let me know what do you think is the right thing here given that we don't want to break 24.3 compatibility. The current master is pointing to 2025.2 EAP, so simply waiting may not be sufficient to get this working in older version of IDEA without workarounds. As I mentioned in the thread, I think that previous implementation was ok, as it will only change images rendering in markdown if user specifies their own image loader. But if their loader works correctly, it will probably be able to render markdown images too as we don't really overwrite an image loader provider if it exists.