Fix IrSimpleFunction.isLegacyOpenFunctionWithDefault
#5588
Merged
+48
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekxu16
requested review from
ShikaSD,
andrewbailey,
bentrengrove and
chuckjaz
as code owners
Compilation of overrides of `@Composable` methods can fail when the methods are arranged across packages in certain ways, e.g. how they are arranged in `ComposeCrossModuleTests.testLegacyOpenFunctionWithDefaultFalsePositives`. This CL fixes the root cause of the failures by making `IrSimpleFunction.isLegacyOpenFunctionWithDefault` account for the fact that `composeMetadata` can only appear on the root of an override tree. Test: ComposeCrossModuleTests.testLegacyOpenFunctionWithDefaultFalsePositives Bug: 461766771
derekxu16
force-pushed
the
prr/derekx/fix-is-legacy-open-function-with-default
branch
from
b84ea20 to
f504531
Compare
derekxu16
changed the title
@Composable methodsIrSimpleFunction.isLegacyOpenFunctionWithDefault
ShikaSD
approved these changes
Dec 8, 2025
Collaborator
|
Let's also request a cherry-pick to 2.3.10, this seems pretty significant for the internal build. |
Collaborator
Author
|
/safe-merge |
|
Quality gate is triggered at https://buildserver.labs.intellij.net/build/837559140 — use this link to get full insight. Quality gate was triggered with the following revisions:
|
|
Quality gate finished successfully. |
KotlinBuild
deleted the
prr/derekx/fix-is-legacy-open-function-with-default
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation of overrides of
@Composablemethods can fail when the methods are arranged across packages in certain ways, e.g. how they are arranged inComposeCrossModuleTests.testLegacyOpenFunctionWithDefaultFalsePositives. This CL fixes the root cause of the failures by makingIrSimpleFunction.isLegacyOpenFunctionWithDefaultaccount for the fact thatcomposeMetadatacan only appear on the root of an override tree.Test: ComposeCrossModuleTests.testLegacyOpenFunctionWithDefaultFalsePositives
Bug: 461766771