Skip to content

Re-add Spigot compatibility#184

Merged
Jikoo merged 10 commits intomasterfrom
dev/update-enchanting
May 5, 2026
Merged

Re-add Spigot compatibility#184
Jikoo merged 10 commits intomasterfrom
dev/update-enchanting

Conversation

@Jikoo
Copy link
Copy Markdown
Owner

@Jikoo Jikoo commented May 1, 2026

  • Re-added Spigot support
    • The full PlanarEnchanting release offers first class Spigot and Paper support.
  • Fixes potential incompatibility with max stack changing plugins
  • Fixes default config containing invalid enchantability category
  • Improved some unit tests (some are still a mess, I just don't have it in me to rewrite them all more properly rather than fix the glaring failures)

Jikoo added 3 commits February 4, 2026 20:32
Fixes potential incompatibility with plugins changing max stack sizes
Jikoo added 2 commits May 1, 2026 12:34
Still annoyed that Sonar doesn't ignore deprecation on an overridden method inherited from external code, like, yeah, I'll get right on removing that some day because it's totally in my control. The override will generate a compile error when it can be removed, I don't need alert fatigue from something outside of my control.
@Jikoo
Copy link
Copy Markdown
Owner Author

Jikoo commented May 1, 2026

Issues so far:

  • Both:
    • Silk does not pause when result is full
    • Something is wrong with prior work handling.
    • Conflicts (and other complex settings) don't load on first run.
  • Spigot:
    • Stacks still can overflow max due to fortune. Unsure if I want to fix this because it prevents losses due to high fortune+efficiency filling furnaces faster than hoppers can remove results. Also unsure if this is Spigot-specific, it's a bit annoying to replicate.
      I have determined that this is a feature, not a bug. I will probably forget I made this determination and encounter it in another couple years only to reach the same conclusion.
    • Spigot bug with applying enchantment hints (and indirectly, with enchanting at all as a result because buttons are disabled)

@Jikoo Jikoo linked an issue May 3, 2026 that may be closed by this pull request
@Jikoo Jikoo merged commit aaa0c69 into master May 5, 2026
5 of 6 checks passed
@Jikoo Jikoo deleted the dev/update-enchanting branch May 5, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

26.1.2

1 participant