Eliminate need for Node assert in browser tests#71
Open
acorncom wants to merge 1 commit intoJimbly:masterfrom
Open
Eliminate need for Node assert in browser tests#71acorncom wants to merge 1 commit intoJimbly:masterfrom
acorncom wants to merge 1 commit intoJimbly:masterfrom
Conversation
Jimbly
requested changes
Oct 23, 2024
| } | ||
| if (glob.Date === MockDate) { | ||
| assert(_Date); | ||
| assert.ok(_Date, 'need to pass a date'); |
Owner
There was a problem hiding this comment.
More accurate message is probably "unregister() called but missing original Date constructor".
|
|
||
| var assert = require('assert'); | ||
| var assert = { | ||
| ok(cond, msg) { |
Owner
There was a problem hiding this comment.
Could probably just be function assert(cond, msg) { as we only use the default export of assert here.
|
Any progress here @acorncom ? I've just ran into the same exact issue; seems like this PR should be pretty easy to close. |
Author
|
@Mink-Mink the PR has been working great in-app on our side, haven't had a chance to come back to cleaning this up. If you've got the time/interest, happy to have you finalize things here |
|
Sure, I'll take a look at making a fresh PR with all the corrections tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howdy, I'm upgrading a client app from Webpack 4 -> 5 (yes, I know it's old). As part of that, we hit the below wrinkle with
timezone-mock:It turns out the polyfill for
assertis relatively heavy in a browser context andassertusage here was pretty minimal. So thought I'd send this over as a possible fix. I can add better comments or a test to check in a browser context if desired, but thought I'd check to see if you were at all interested in the change.Thanks for your work on this!