Skip to content

Issue 46 regarding signin signup #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JiyaBatra merged 4 commits into from
Mar 14, 2026
Merged

Issue 46 regarding signin signup #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90564e6
false commit
dipesh-2874 Mar 12, 2026
cf6a979
true commit
dipesh-2874 Mar 12, 2026
5d011eb
Add: issue regarding signup and signin
dipesh-2874 Mar 12, 2026
f74c259
Merge branch 'main' into issue-46-regarding-signin-signup
JiyaBatra Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,22 @@ if (signupForm) {
return;
}

window.location.href = getMainPagePath("signin.html");
// if username already exists
const userExists = users.some(user => user.email === email);

if (userExists) {
error.textContent = "User already exists!";
return;
}

// new user
const newUser = { username, email, password };
users.push(newUser);
localStorage.setItem("users", JSON.stringify(users));

localStorage.setItem("loggedIn", "true");
localStorage.setItem("loggedInUser", username);
window.location.href = getMainPagePath("index.html");
});
}

Expand Down
4 changes: 2 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!doctype html>
<!DOCTYPE html>
<html lang="en">

<head>
Expand Down Expand Up @@ -168,12 +168,12 @@ <h3>Tic Tac Toe</h3>

<!-- AUTH SYSTEM -->
<script src="auth.js"></script>
<script src="script.js"></script>
<script>
checkAuth(); // protect page
showLoggedInUser(); // show username
</script>

<script src="script.js"></script>

</body>

Expand Down
2 changes: 1 addition & 1 deletion signin.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ <h2>Login</h2>
}
</script>
</body>
</html>
</html>
2 changes: 1 addition & 1 deletion signup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ <h2>Create Account</h2>
}
</script>
</body>
</html>
</html>
Loading