update to minecraft 1.21.7, gradle to 8.14, TextPlaceholderAPI (use new methods)#341
Merged
Merged
Conversation
|
Review changes with Changed Files
|
John-Paul-R
commented
Jul 9, 2025
Comment on lines
+125
to
+127
| var ret = Text.empty(); | ||
| parsedText.getWithStyle(specifiedStyle).forEach(ret::append); | ||
| return ret; |
Owner
Author
There was a problem hiding this comment.
potentially worth checking that there was no reason I was avoiding this (e.g. prestyled text that's supposed to cascade down to children still) and that there's no reason to avoid this for the "one node" case...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.