Skip to content
This repository has been archived by the owner on Jan 4, 2020. It is now read-only.

[WIP]: Min deployment target #192

Closed
wants to merge 7 commits into from

Conversation

acecilia
Copy link

@acecilia acecilia commented Nov 9, 2018

Implementation for passing the minimum deployment target in an inline comment from inside the script, and also adding it in the marathonFile. In addition, when running in macos, the minimum deployment target is obtained from the machine where Marathon is executed.

This is WIP. Can I get some initial feedback on this? Thanks!

TODO:

  • Add tests

Example:

  • Inline, inside the script, you can specify:
    // marathon:min-deployment-target:x86_64-apple-macosx10.13

  • In the MarathonFile you can specify:
    min-deployment-target:x86_64-apple-macosx10.13

  • Also, if running in macos you do not need to specify anything: the system version will be used as minimum deployment target.

MarathonFile configuration has priority over the one specified inside the script

@acecilia acecilia changed the title Min macos version Min deployment target Nov 11, 2018
@acecilia acecilia changed the title Min deployment target [WIP]: Min deployment target Nov 12, 2018
@jsorge
Copy link

jsorge commented Feb 9, 2019

Is this still happening? I just tried to make my first script and need ISO8601DateFormatter and can't use it. Sad day!

@JohnSundell
Copy link
Owner

Thanks a lot for this contribution @acecilia (and so sorry for the late reply), but I'm afraid this is out of scope for Marathon (I'm going to limit Marathon's scope a bit going forward, to make it more realistic for me to maintain). Thanks anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants