This repository has been archived by the owner on Jan 4, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for passing the minimum deployment target in an inline comment from inside the script, and also adding it in the marathonFile. In addition, when running in macos, the minimum deployment target is obtained from the machine where Marathon is executed.
This is WIP. Can I get some initial feedback on this? Thanks!
TODO:
Example:
Inline, inside the script, you can specify:
// marathon:min-deployment-target:x86_64-apple-macosx10.13
In the MarathonFile you can specify:
min-deployment-target:x86_64-apple-macosx10.13
Also, if running in macos you do not need to specify anything: the system version will be used as minimum deployment target.
MarathonFile configuration has priority over the one specified inside the script