Comments on Readme#1
Open
JohnZed wants to merge 2 commits into
Open
Conversation
This looks super-helpful, Matt! I hope you don't mind my pedantic comments... I think installation instructions are the most important (ideally aligned with other RAPIDS installation). Is there a docker container to try this out? Would be great to mention that too. Otherwise, adding a bit more big-picture around data movement and placement would be the other thing to thing about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry this is not a real PR! I couldn't find an easy way to just comment on the code directly when it's not in a PR...
This looks super-helpful, Matt! I hope you don't mind my pedantic comments... I think installation instructions are the most important (ideally aligned with other RAPIDS installation). Is there a docker container to try this out? Would be great to mention that too.
Otherwise, adding a bit more big-picture around data movement and placement would be the other thing to thing about.