[pull] main from agglayer:main#122
Merged
Merged
Conversation
#1537) Fixes #1316 Incidentally, remove the parameters copied from the job for now; we can re-add them whenever we are ready to implement all the API that would actually use them. For now it makes the code slightly simpler, and we need to focus on simplicity. Finally, remove the validium-specific config, as we agreed to not have validium settlement go through the settlement service.
Use RocksDB prefix iteration for settlement attempt history reads. Settlement attempts and attempt results now iterate from the encoded SettlementJobId prefix, so RocksDB enforces the job boundary instead of storage code seeking and checking each decoded key. Fixes #1539. Verified with: - cargo make blast-radius - cargo check --workspace --tests --all-features - mdbook build docs/knowledge-base/ - cargo make ci-all - cargo nextest run --workspace - cargo make pp-check-vkey-change - git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )