[pull] main from agglayer:main#129
Merged
Merged
Conversation
#1567) Removes the direct SP1 SDK dependencies from agglayer-types so it reaches SP1 only through the agglayer-sp1 facade (issue #1524, epic #1541). - Drop sp1-sdk, sp1-sdk-v5, sp1-core-machine and sp1-prover from agglayer-types; sp1-core-machine and sp1-prover were already unused. - Move the test-only mock-proof builder dummy_sp1_stark_proof_with_version (and its private serialize helper) into agglayer-sp1::testutils, and re-export it from agglayer_types::testutils so every consumer (agglayer-storage, agglayer-grpc-api, agglayer-grpc-types, internal tests) is unchanged. - Public API of agglayer-types is unchanged. The v5 mock path is preserved; full v5 SDK removal is tracked separately in #1511. Verification: cargo check --workspace --tests --all-features; workspace clippy -D warnings; nightly fmt --check; cargo nextest for agglayer-sp1 and agglayer-types (28 passed); consumer tests (agglayer-storage types 121, grpc-types compat 19, grpc-api cert-submission 1). Closes #1524
) The node startup log printed `VERGEN_IDEMPOTENT_OUTPUT` instead of a version because the Docker build never receives a `.git` directory, so vergen cannot derive the git describe/timestamp at compile time. Resolve the version at compile time from `AGGLAYER_BUILD_DESCRIBE` and `AGGLAYER_BUILD_TIMESTAMP` when set, falling back to vergen's git-derived values. Local `cargo build` keeps auto-versioning from `.git`; Docker and CI builds pass the values explicitly. - main.rs: prefer the override env vars, fall back to vergen - build.rs: rerun the build script when the override vars change - Dockerfile: declare ARG/ENV before `cargo build`, after chef cook so the dependency cache is preserved - docker-build.yml / release.yml: fetch full history and tags, compute `git describe --tags --always --dirty` and the commit timestamp, and pass them as build-args A build without the override degrades to vergen's previous behavior instead of breaking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )