[pull] main from agglayer:main#130
Merged
Merged
Conversation
## Summary - move persisted settlement-attempt hydration into a pure helper - make settlement-attempt DB loading synchronous - remove the test-only job-id helper and add focused hydration tests Follow-up PR from #1552 ## Verification - cargo make blast-radius - cargo make generate-proto - cargo check --workspace --tests --all-features - mdbook build docs/knowledge-base/ - cargo make ci-all - cargo make pp-check-vkey-change - cargo test -p agglayer-clock skipped_blocks_are_handled -- --test-threads=1 Note: cargo nextest run --workspace failed in agglayer-clock skipped_blocks_are_handled cases during the broad parallel run; the same three cases passed in the targeted serial rerun above.
Persist each settlement attempt before submitting it to L1 so pending settlement jobs can recover attempt metadata after restart. The attempt is written to storage before in-memory tracking, and storage write failures panic because settlement storage errors are not recoverable. Tests cover successful persistence, storage-write failure, and duplicate attempt-number protection. Fixes #1320 --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )