Skip to content

Improve n-dimensional slicing of BlockIndexRange #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mtfishman
Copy link
Collaborator

@mtfishman mtfishman commented Jun 25, 2025

Fixes #355. This is also fixed as a part of #462 but this PR is narrower in scope so could be merged more quickly.

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (f6c5555) to head (a38d45e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #463   +/-   ##
=======================================
  Coverage   93.67%   93.68%           
=======================================
  Files          19       19           
  Lines        1677     1678    +1     
=======================================
+ Hits         1571     1572    +1     
  Misses        106      106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dlfivefifty
Copy link
Member

@mtfishman I think you have write access? Feel free to merge small changes like this, if downstream tests pass and you are confident it isn't going to cause problems.

@dlfivefifty dlfivefifty merged commit a1c89dc into JuliaArrays:master Jul 1, 2025
16 checks passed
@mtfishman
Copy link
Collaborator Author

@mtfishman I think you have write access? Feel free to merge small changes like this, if downstream tests pass and you are confident it isn't going to cause problems.

Yes, I have write access, will do.

@mtfishman mtfishman deleted the mf/blockindexrange_nd_indexing branch July 1, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slicing a BlockIndexRange with unit ranges doesn't return a BlockedIndexRange
2 participants