Skip to content

Preserve blocking of indices when slicing a unit range with a blocked unit range #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mtfishman
Copy link
Collaborator

Fixes #367.

Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (e9c28d4) to head (e5b882a).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #465       +/-   ##
===========================================
+ Coverage    0.00%   93.88%   +93.88%     
===========================================
  Files          19       19               
  Lines        1689     1716       +27     
===========================================
+ Hits            0     1611     +1611     
+ Misses       1689      105     -1584     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
Copy link
Collaborator Author

Failing tests should be fixed by #473.

@mtfishman mtfishman requested a review from dlfivefifty July 1, 2025 16:18
@dlfivefifty dlfivefifty merged commit ecb8f8f into JuliaArrays:master Jul 10, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getindex(::UnitRange, ::BlockedUnitRange) isn't blocked
2 participants